chore: updated retry parameters to check transaction mined status #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashk767
force-pushed
the
yash/raz-1038-need-to-update-timeout-window-for-waitforblockcompletion-for
branch
from
e595d23 to
e16733e
Compare
ashish10677
approved these changes
Oct 18, 2024
rajkharvar
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Behavior: The node was reporting transactions as failed because the timeout for checking the transaction status was too short compared to the time required for a transaction to be confirmed. While this is not an issue as mined status is not serving any major purpose, it is a suggested improvement to enhance the user experience.
Proposed Changes: Increased the number of retries and the delay between them to extend the interval for checking the transaction status. The interval has been increased from
3 secondsto8 secondsto allow more time for checking the transaction to be mined.Fixes https://linear.app/interstellar-research/issue/RAZ-1038