Skip to content

chore: revised max/min value for config parameters #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Yashk767
Copy link
Contributor

Description

Updated minimum values for RPCTimeout and HTTPTimeout to make less restrictive for a staker.
And updated maximum value for waitTime as that should be equal to the buffer time until next state starts.

Fixes https://linear.app/interstellar-research/issue/RAZ-1023

@Yashk767 Yashk767 force-pushed the yash/raz-1023-revise-max-and-min-values-for-config-parameters branch from 9ac453f to 0bfaad1 Compare October 23, 2024 09:32
@Yashk767 Yashk767 marked this pull request as ready for review October 23, 2024 09:33
@Yashk767 Yashk767 merged commit 98ef5c1 into develop Oct 29, 2024
5 checks passed
@Yashk767 Yashk767 deleted the yash/raz-1023-revise-max-and-min-values-for-config-parameters branch October 30, 2024 12:46
Yashk767 added a commit to Yashk767/razor-go that referenced this pull request Mar 18, 2025
* refactor: added context with timeout to retry mechanism (razor-network#1235)

* chore: updated config variable default and limits for 5 min epoch (razor-network#1232)

* feat: added timeout to retry mechanism using context

* refactor: called stateBuffer once and used in other functions

* refactor: added context to RPC calls used in vote function

* refactor: added context instance to all the dependent functions

* refactor: fixed tests for cmd package

* refactor: fixed tests for utils package

* refactor: fixed additional tests in cmd package

* refactor: fixed benchmarks in cmd package

* refactor: reduced number of retry attempts

* refactor: added tests for context deadline exceeded for retry case

* refactor: rebased retry params with current main branch v2.0.0 release

* refactor: replaced retry implementation inside functions with generic retry function (razor-network#1252)

* refactor: replaced retry implementation with genernic retry function

* refactor: used generic retry function instead of individual retry implementation

* refactor: reverted nil with exisiting 0 big integer when error occurs in fetchBalance

* fix: added context parameter to functions to sync with updated generic retry function to make build successful (razor-network#1256)

* refactor: used generic retry function instead of individual retry implementation

* refactor: reverted nil with exisiting 0 big integer when error occurs in fetchBalance

* fix: added context to function parameters foe successfull build

* refactor: fixed tests

* refactor: fixed benchmarks

* refactor: replaced SKL with sFuel as a gas token in logs (razor-network#1253)

* refactor: replaced SKL with sFuel as a gas token in logs

* refactor: lowered the value for minimum sFuel required to warn the staker to add more

* refactor: rename sFuel to sFUEL

* feat: added commitment verification layer for data during reveal after removing waitForBlockCompletion check for voting transactions (razor-network#1254)

* refactor: added verification layer on commit data from memory

* refactor: removed waitForBlockCompletion from propose and reveal

* fix: returned err instead of nil in GetConfirmedBlock

* reafctor: fixed tests

* refactor: fixed lint errors

* fix: returned supported struct type and added a condition to attempt confirmBlock when node just started voting

* refactor: fixed tests after rebasing

* refactor: removed commented unwanted tests

* refactor: Fetched selected commit data first and than applied commitment verification

* feat: saved commitment in the memory/file along with commit data and reused it in reveal

* chore: updated retry parameters to check transaction mined status (razor-network#1255)

* chore: updated parameters to check transaction mined status

* feat: added timeout over WaitForBlockCompletion

* chore: revised max/min value for config parameters (razor-network#1257)

* chore: updated go and geth version (razor-network#1259)

* chore: updated geth and go version

* chore: update go and geth version for docker and workflows

* ci: fixed ci by updating dependencies

* ci: fix line change error

* feat: Implemented RPC Manager for RPC calls (razor-network#1260)

* feature: introduced RPC manager module

* feat: Implemented RPCParameters for all contract calls

* refactor: moved RPCParameters struct to RPC module

* fix: added assetId parameter to getActiveStatus retry call

* refactor: passed rpcParameters to Batch call functions instead of client

* fix: path to assets.json and client parameter index fixed

* refactor: tests/updated mocks

* refactor: revert mainnet addresses change

* fix: added ctx parameter in CheckTransactionReceipt

* fix: revert chain Id and contract addresses change

* fix: refreshed RPC list after confirm state every epoch

* fix: added disputes contract call to the blockManager struct

* refactor: fixed lint log error

* reafctor: fixed tests

* fix: calculated dynamically the path to endpoints.json file

* fix: endpoints.json file to be picked from .razor directory instaed of repo

* refactor: set up temp endpoints.json file for tests

* feat: added importEndpoints command

* refactor: removed alternateProvider functions and flag as its not required now

* fix: switch to next client only if the connection is successful

* feat: added state block check by introducing blockMonitor (razor-network#1262)

* feat: introduced block monitor to keep track of blocks

* refactor: removed global variables used in logger and added blockMonitor as a field

* refactor: used refactored logger module

* fix: fixed logger global instance

* refactor: exported logrus instance field from logger struct

* refactor: fixed tests

* refactor: removed  unwanted return variables in tests

* refactor: added log for current best endpoint URL after every refresh

* fix: added endpoint validation while switching endpoints

* fix: added switched returned type while switching endpoints and removed staleBlockCallback field

* refactor: used BestRPCClient from BestEndpoint

* refactor: renamed RPC module to rpc

* refactor: removed unwanted logs

* refactor: corrected importEndpoints command info

* refactor: removed fatal logs from GetTxnOpts() (razor-network#1261)

* refactor: removed fatal logs from GetTxnOpts()

* refactor: removed fatal log when address not found

* reafctor: fixed tests

* fix: removed cancel context being called immediately after creation (razor-network#1265)

* refactor: added tests for rpc module (razor-network#1266)

* refactor: added tests for RPC module

* Revert "refactor: added tests for RPC module"

This reverts commit bac5b3b.

* reafctor: added tests for rpc module using httpstest servers

* ci: updated artifact version for binary downloads and uploads

* ci: fixed ci by updateing action versions

* reafctor: replaced ts.cancel() with  t.Cleanup(func() { ts1.Close() })

* fix: switch RPC if block number is less than last recorded block number (razor-network#1264)

* fix: switch RPC if block number is less than last recorded block number

* refactor: added tests for block module

* refactor: fetched block number from block monitor module in voting process (razor-network#1269)

* refactor: fetched block number from block monitor in voting

* refactor: fixed tests

* fix: added nil check for header from block monitor

* refactor: replaced empty block monitor reference with nil in case of error

* fix: added validation to check if index to fetch element is within limits (razor-network#1270)

* fix: setconfig command fails on new vm for the first run of a staker (razor-network#1271)

* hotfix: removed getConfigData() call from setConfig command

* chore: update version to v2.1.0

* refactor: removed unwanted 'InitializeCommandDependencies()' from import and create command

* ci: updated actions/cache from v2 to v4 (razor-network#1272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants