Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): support width prop on DropdownOverlay #1825

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

pritipsingh
Copy link
Contributor

@pritipsingh pritipsingh commented Nov 19, 2023

This PR is in reference to adding width support to DropdownOverlay. Now users can choose to have the width of the dropdown or it will be set to "100%"

Fixes #1660

Copy link

changeset-bot bot commented Nov 19, 2023

🦋 Changeset detected

Latest commit: 4365754

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4365754:

Sandbox Source
razorpay/blade: basic Configuration

@pritipsingh
Copy link
Contributor Author

noted & understood the context - will make the changes @saurabhdaware

Copy link
Contributor

github-actions bot commented Nov 21, 2023

✅ PR title follows Conventional Commits specification.

@pritipsingh
Copy link
Contributor Author

@saurabhdaware can you check now? Have made all the changes and looks clean now!

@snitin315 snitin315 changed the title Support width prop on ActionList / DropdownOverlay #1660 feat: support width prop on ActionList / DropdownOverlay #1660 Dec 1, 2023
Copy link

bundlemon bot commented Dec 1, 2023

BundleMon

Files updated (1)
Status Path Size Limits
Web Components
build/components/index.production.web.js
330.03KB (+12B 0%) -
Unchanged files (13)
Status Path Size Limits
React Native Components
build/components/index.native.js
187.05KB -
Web Tokens
build/tokens/index.production.web.js
42.24KB -
React Native Tokens
build/tokens/index.native.js
38.35KB -
CSS Theme Tokens
build/css/paymentThemeDarkDesktop.css
4.55KB -
CSS Theme Tokens
build/css/paymentThemeDarkMobile.css
4.54KB -
CSS Theme Tokens
build/css/bankingThemeLightDesktop.css
4.53KB -
CSS Theme Tokens
build/css/bankingThemeLightMobile.css
4.52KB -
CSS Theme Tokens
build/css/bankingThemeDarkDesktop.css
4.52KB -
CSS Theme Tokens
build/css/paymentThemeLightDesktop.css
4.52KB -
CSS Theme Tokens
build/css/bankingThemeDarkMobile.css
4.51KB -
CSS Theme Tokens
build/css/paymentThemeLightMobile.css
4.51KB -
Web Utils
build/utils/index.production.web.js
3.38KB -
React Native Utils
build/utils/index.native.js
2.27KB -

Total files change +13B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@saurabhdaware saurabhdaware self-requested a review December 6, 2023 06:12
@saurabhdaware saurabhdaware changed the title feat: support width prop on ActionList / DropdownOverlay #1660 feat(Dropdown): support width prop on DropdownOverlay Dec 6, 2023
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Thanks for the PR 🥳

@saurabhdaware saurabhdaware self-assigned this Dec 6, 2023
@saurabhdaware saurabhdaware merged commit e89018c into razorpay:master Dec 6, 2023
anuraghazra pushed a commit that referenced this pull request Apr 9, 2024
* Support width prop on ActionList / DropdownOverlay #1660

* fix: changed width type from string to BoxProps

* Create pretty-wolves-deny.md

---------

Co-authored-by: Saurabh Daware <saurabhdaware99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support width prop on ActionList / DropdownOverlay
2 participants