-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): support width
prop on DropdownOverlay
#1825
Conversation
🦋 Changeset detectedLatest commit: 4365754 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4365754:
|
packages/blade/src/components/Dropdown/StyledDropdownOverlay.tsx
Outdated
Show resolved
Hide resolved
noted & understood the context - will make the changes @saurabhdaware |
✅ PR title follows Conventional Commits specification. |
@saurabhdaware can you check now? Have made all the changes and looks clean now! |
BundleMonFiles updated (1)
Unchanged files (13)
Total files change +13B 0% Final result: ✅ View report in BundleMon website ➡️ |
width
prop on DropdownOverlay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. Thanks for the PR 🥳
* Support width prop on ActionList / DropdownOverlay #1660 * fix: changed width type from string to BoxProps * Create pretty-wolves-deny.md --------- Co-authored-by: Saurabh Daware <saurabhdaware99@gmail.com>
This PR is in reference to adding width support to DropdownOverlay. Now users can choose to have the width of the dropdown or it will be set to "100%"
Fixes #1660