Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add codemod for Table & Spinner #1976

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jan 17, 2024

  • some perf improvements.

Spinner

  • The contrast prop has been removed in favor of the color prop.

    - <Spinner contrast="low" />
    + <Spinner color="primary" />
    
    - <Spinner contrast="high" />
    + <Spinner color="white" />
  • The "default" value for the color prop has been removed in favor of the new "primary" value.

    - <Spinner color="default" />
    + <Spinner color="primary" />

Table

  • The surfaceLevel prop has been removed without replacement.

    - <Table data={tableData} surfaceLevel={1}>
    + <Table data={tableData} >

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: d1873f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 17, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1873f5:

Sandbox Source
razorpay/blade: basic Configuration

@chaitanyadeorukhkar
Copy link
Collaborator

chaitanyadeorukhkar commented Jan 17, 2024

This needs discussion

@snitin315 snitin315 changed the title refactor: add codemod for Table refactor: add codemod for Table & Spinner Jan 17, 2024
@snitin315
Copy link
Member Author

merging to unblock open PRs

@snitin315 snitin315 merged commit cc209df into rebranding/master Jan 18, 2024
14 of 15 checks passed
@snitin315 snitin315 deleted the table-codemod branch January 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants