Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add breadcrumb tests #2029

Merged
merged 5 commits into from
Feb 29, 2024
Merged

test: add breadcrumb tests #2029

merged 5 commits into from
Feb 29, 2024

Conversation

anuraghazra
Copy link
Member

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a165d6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

✅ PR title follows Conventional Commits specification.

@anuraghazra anuraghazra added the Review - L1 First level of review label Feb 21, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 21, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a165d6c:

Sandbox Source
razorpay/blade: basic Configuration

snitin315
snitin315 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought we were writing only E2E tests for new components.

snitin315
snitin315 reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking show code it's not showing the code actual code but just the <RouterExample />

Screenshot 2024-02-22 at 5 19 44 PM

@anuraghazra
Copy link
Member Author

I'll add codesandbox link

@snitin315 snitin315 removed their assignment Feb 26, 2024
@snitin315 snitin315 added Review - L2 Second level of review and removed Review - L1 First level of review labels Feb 26, 2024
saurabhdaware
saurabhdaware approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No E2E needed?

@anuraghazra
Copy link
Member Author

No E2E needed?

Nope, nothing to test.

@anuraghazra anuraghazra merged commit 9d784ed into anu/breadcrumb Feb 29, 2024
13 of 15 checks passed
@anuraghazra anuraghazra deleted the anu/breadcrumb-test branch February 29, 2024 05:37
anuraghazra added a commit that referenced this pull request Feb 29, 2024
@anuraghazra
feat(blade): add Breadcrumb component (#2028)
bb7466e 
* feat: add breadcrumb implementation

* chore: add docs

* chore: update native files

* refactor: use react context

* chore: add meta

* chore: update docs

* chore: test

* chore: reexport

* Create five-cows-cheer.md

* chore: add multiline example & fix spacing

* chore: update

* chore: update types

* chore: update opacity token

* test: add breadcrumb tests (#2029)

* test: add breadcrumb tests

* chore: add breadcrumb kitchen sink

* chore: update snaos

* chore: update story

* chore: update code url
anuraghazra added a commit that referenced this pull request Apr 9, 2024
@anuraghazra
feat(blade): add Breadcrumb component (#2028)
c6c96fe 
* feat: add breadcrumb implementation

* chore: add docs

* chore: update native files

* refactor: use react context

* chore: add meta

* chore: update docs

* chore: test

* chore: reexport

* Create five-cows-cheer.md

* chore: add multiline example & fix spacing

* chore: update

* chore: update types

* chore: update opacity token

* test: add breadcrumb tests (#2029)

* test: add breadcrumb tests

* chore: add breadcrumb kitchen sink

* chore: update snaos

* chore: update story

* chore: update code url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@saurabhdaware saurabhdaware saurabhdaware approved these changes

@chaitanyadeorukhkar chaitanyadeorukhkar Awaiting requested review from chaitanyadeorukhkar

@kamleshchandnani kamleshchandnani Awaiting requested review from kamleshchandnani

Assignees

@saurabhdaware saurabhdaware

Labels
Review - L2 Second level of review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraghazra @saurabhdaware @snitin315