feat: Redesign all Input components
#2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2e58b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2e58b8:
|
anuraghazra
previously approved these changes
Feb 29, 2024
packages/blade/src/components/Input/BaseInput/AnimatedBaseInputWrapper.native.tsx
Outdated
Show resolved
Hide resolved
| * trailingActionButton={<Link onClick={handleClick}>Apply</Link>} | ||
| * ``` | ||
| */ | ||
| trailingActionButton?: React.ReactElement<LinkProps>; |
There was a problem hiding this comment.
What if we just do trailingButton or trailingAction? Button implies Action no?
packages/blade/src/components/Input/BaseInput/StyledBaseInput.native.tsx
Show resolved
Hide resolved
packages/blade/src/components/Input/BaseInput/baseInputStyles.ts
Outdated
Show resolved
Hide resolved
packages/blade/src/components/Input/BaseInput/baseInputStyles.ts
Outdated
Show resolved
Hide resolved
saurabhdaware
previously approved these changes
Mar 4, 2024
chaitanyadeorukhkar
requested review from
kamleshchandnani and
snitin315
as code owners
chaitanyadeorukhkar
changed the title
Input components RedesignInput components
saurabhdaware
approved these changes
Mar 27, 2024
anuraghazra
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Changes ### TextInput - Redesigned UI - Add `leadingIcon` prop -⚠️ Deprecate `icon` prop in favour of `leadingIcon` which will be removed in the next major version - Add `trailingIcon` prop - Add `trailingLinkButton` prop - Add `size` prop ### TextArea - Redesigned UI - Add `size` prop ### PasswordInput - Redesigned UI - Adds `size` prop ### OTPInput - Redesigned UI - Add `size` prop ### SelectInput - Redesigned UI - Add `size` prop ### Autocomplete - Redesigned UI - Add `size` prop ### Radio - Add `size` prop ### Checkbox - Add `size` prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redesign of
Inputfamily components.BaseInput
trailingIconproptrailingLinkButtonpropsizepropTextInput
leadingIconpropiconprop in favour ofleadingIcontrailingIconproptrailingLinkButtonpropsizepropTextArea
sizepropPasswordInput
sizepropOTPInput
sizepropSelectInput
sizepropAutocomplete
sizepropRadio
sizepropCheckbox
sizepropChanges
Additional Information
Component Checklist