Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blade): Alert custom icon added #2059

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

harsh9975
Copy link
Contributor

@harsh9975 harsh9975 commented Mar 3, 2024

Description

Fixes #2019

This PR adds the feature to add custom icons for Alert which was mentioned in #2019. I referred to the PR by @anuraghazra #2000

Changes

Added leading field to add custom icons.

Additional Information

Screenshot 2024-03-03 at 6 06 11 PM Screenshot 2024-03-03 at 6 07 01 PM

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

hire me

HIRE ME

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: 3f04f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 3, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Mar 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f04f91:

Sandbox Source
razorpay/blade: basic Configuration

Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll discuss with team once about this change from design perspective. Otherwise added some comments

Co-authored-by: Saurabh Daware <saurabhdaware99@gmail.com>
@saurabhdaware saurabhdaware added the Waiting for Changes Waiting for changes from PR author label Apr 4, 2024
@harsh9975 harsh9975 requested a review from anuraghazra April 18, 2024 10:29
saurabhdaware
saurabhdaware previously approved these changes Apr 25, 2024
@saurabhdaware saurabhdaware removed the Waiting for Changes Waiting for changes from PR author label Apr 25, 2024
@saurabhdaware saurabhdaware merged commit 23a8364 into razorpay:master Apr 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make Alert component's leading icon configurable
3 participants