fix: ButtonGroup focus ring styles #2091
Conversation
snitin315
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra and
saurabhdaware
as code owners
|
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e762c56:
|
| borderColor: getIn( | ||
| theme.colors, | ||
| getBackgroundColorToken({ | ||
| // Only secondary variant has border a border, for other variants we use background color so that the border is not visible |
There was a problem hiding this comment.
Why not make it transparent?
There was a problem hiding this comment.
transparent doesn't work. BorderRadius is not getting applied.
| @@ -10,22 +10,19 @@ const StyledButtonGroup = styled(BaseBox)<StyledButtonGroupProps>( | |||
| return { | |||
| display: 'flex', | |||
| width: isFullWidth ? '100%' : 'fit-content', | |||
| overflow: 'hidden', | |||
There was a problem hiding this comment.
was this causing issue with focus ring? (storybook is broken right now so unable to preview before and after https://razorpay.slack.com/archives/G01B3LQ9H0W/p1710930648131329)
snitin315
force-pushed
the
fix-buttongroup-focus
branch
from
a931144 to
e762c56
Compare
Description
Fixed the focus ring styles.
Changes
Screen.Recording.2024-03-20.at.12.48.32.PM.mov