Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blade): radio & checkbox large size #2092

Merged

Conversation

anuraghazra
Copy link
Member

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 3c9f25f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c9f25f:

Sandbox Source
razorpay/blade: basic Configuration

Copy link
Contributor

github-actions bot commented Mar 20, 2024

✅ PR title follows Conventional Commits specification.

@rzpcibot
Copy link
Collaborator

rzpcibot commented Mar 20, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.428 7.363 -0.065 KB
ActionList, ActionListItem, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 12.546 12.596 +0.050 KB
Alert 11.576 11.513 -0.063 KB
Amount 1.182 1.099 -0.083 KB
Badge 0.903 0.821 -0.082 KB
BladeProvider 1.729 1.646 -0.083 KB
BottomSheet 9.568 9.484 -0.084 KB
Box 0.837 0.741 -0.096 KB
Breadcrumb, BreadcrumbItem 2.615 2.545 -0.070 KB
ButtonGroup 1.228 1.162 -0.066 KB
Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing 9.225 9.162 -0.063 KB
Carousel, CarouselItem 6.899 6.828 -0.071 KB
Checkbox 5.943 6.002 +0.059 KB
Chip, ChipGroup 5.425 5.355 -0.070 KB
Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody 9.470 9.425 -0.045 KB
Counter 0.848 0.770 -0.078 KB
Divider 0.622 0.534 -0.088 KB
Drawer, DrawerBody, DrawerHeader 16.017 15.948 -0.069 KB
Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 22.778 22.704 -0.074 KB
FileUpload 13.333 13.367 +0.034 KB
Indicator 0.989 0.913 -0.076 KB
List, ListItem, ListItemLink, ListItemCode, ListItemText 5.134 5.069 -0.065 KB
Modal 12.643 12.579 -0.064 KB
Popover, PopoverInteractiveWrapper 20.402 20.324 -0.078 KB
ProgressBar 1.772 1.707 -0.065 KB
Radio 4.784 4.766 -0.018 KB
Skeleton 0.839 0.785 -0.054 KB
SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep 28.348 28.296 -0.052 KB
Switch 4.637 4.542 -0.095 KB
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions 50.419 51.511 +1.092 KB
Tabs, TabItem, TabList, TabPanel 6.677 6.600 -0.077 KB
Tag 3.499 3.431 -0.068 KB
ToastContainer, useToast 12.786 12.729 -0.057 KB
Tooltip, TooltipInteractiveWrapper 15.280 15.199 -0.081 KB
Button 6.027 5.961 -0.066 KB
IconButton 0.859 0.789 -0.070 KB
CheckboxGroup 4.056 4.165 +0.109 KB
SelectInput, AutoComplete 17.481 18.521 +1.040 KB
OTPInput 11.521 12.645 +1.124 KB
PasswordInput 13.619 14.613 +0.994 KB
TextArea 11.894 12.937 +1.043 KB
TextInput 13.502 14.595 +1.093 KB
Link 2.184 2.115 -0.069 KB
RadioGroup 4.030 4.128 +0.098 KB
Spinner 1.977 1.930 -0.047 KB
Code 0.685 0.608 -0.077 KB
Display 0.598 0.510 -0.088 KB
Heading 0.564 0.000 -0.564 KB
Text 0.077 0.002 -0.075 KB

Generated by 🚫 dangerJS against 3c9f25f

Comment on lines 5 to 9
### Patch Changes

- 2c64f181: feat: support `defaultPlacement` prop on `DropdownOverlay`
- ef68789a: fix(DropdownButton): scroll handling issues on keyboard navigations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad rebase.

large: {
width: size[20],
height: size[20],
dotRadius: size['3.75'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 4? Why do we even have a size in float?

@chaitanyadeorukhkar chaitanyadeorukhkar merged commit f66e5a1 into feat/base-input-ui-changes Mar 26, 2024
13 of 16 checks passed
@chaitanyadeorukhkar chaitanyadeorukhkar deleted the feat/checkbox-radio-large branch March 26, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants