Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add large size in FileUpload component #2108

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 1, 2024

Description

Adds large size in FileUpload component.

Changes

  • Add new size prop.
large medium
Screenshot 2024-04-01 at 11 17 17 PM Screenshot 2024-04-01 at 11 19 16 PM
Screenshot 2024-04-01 at 11 17 07 PM Screenshot 2024-04-01 at 11 19 30 PM

Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 1b4d534

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 1, 2024

✅ PR title follows Conventional Commits specification.

@rzpcibot
Copy link
Collaborator

rzpcibot commented Apr 1, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
FileUpload 13.406 13.496 +0.090 KB

Generated by 🚫 dangerJS against 1b4d534

Copy link

codesandbox-ci bot commented Apr 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b4d534:

Sandbox Source
razorpay/blade: basic Configuration

@snitin315 snitin315 added the Review - L1 First level of review label Apr 2, 2024
onPreview,
onRemove,
onDismiss,
size: containerSize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set the default size here instead of ??

Copy link
Member

@anuraghazra anuraghazra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit 8c5231d into master Apr 4, 2024
18 checks passed
@snitin315 snitin315 deleted the fix/fileupload-large-variant branch April 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - L1 First level of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants