Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blade): phone number input dropdown not opening #2135

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

anuraghazra
Copy link
Member

@anuraghazra anuraghazra commented Apr 22, 2024

Description

fixes #2136

With the #2119 PR we added an onClick handler to the BaseInputWrapper to be able to focus the input whenever user clicks on the Input wrapper.

This caused the PhoneInput dropdown to fail like so:

  1. User clicks the PhoneInput
  2. The Dropdown actually opens
  3. But since the BaseInputWrapper also got clicked, the input got focused
  4. Because input got focused the dropdown automatically closed (since dropdowns get closed once blurred)

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: ef8ed06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 22, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Apr 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef8ed06:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Apr 22, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
PhoneNumberInput 48.688 48.697 +0.009 KB

Generated by 🚫 dangerJS against ef8ed06

@anuraghazra anuraghazra merged commit 2f0d96f into master Apr 22, 2024
17 checks passed
@anuraghazra anuraghazra deleted the anu/phoneinput-propagation-fix branch April 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PhoneNumberInput country selector not opening
3 participants