fix: Spinner colors #2309
Merged
fix: Spinner colors #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanyadeorukhkar
requested review from
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
🦋 Changeset detectedLatest commit: 747c86a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 747c86a:
|
Bundle Size ReportUpdated Components
|
saurabhdaware
approved these changes
Jul 15, 2024
Comment on lines
52
to
58
| return getIn(theme.colors, 'interactive.icon.staticWhite.subtle'); | ||
| } | ||
| if (color && color !== 'primary') { | ||
| return getIn(theme.colors, `feedback.background.${color}.intense`); | ||
| if (color && color !== 'neutral') { | ||
| return getIn(theme.colors, `interactive.icon.${color}.subtle`); | ||
| } | ||
| return getIn(theme.colors, 'surface.background.primary.intense'); | ||
| return getIn(theme.colors, 'interactive.icon.gray.subtle'); | ||
| }; |
There was a problem hiding this comment.
Spinner should have surface.icon* colors no? since its not interactive element 🤔
There was a problem hiding this comment.
Good point... on figma its using interactive though
There was a problem hiding this comment.
Asking design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Spinner colors. The colors were incorrectly mapped on code.
Changes
Additional Information
Component Checklist