Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md #2313

Merged
merged 4 commits into from
Jul 19, 2024
Merged

docs: Update README.md #2313

merged 4 commits into from
Jul 19, 2024

Conversation

Anshgrover23
Copy link
Contributor

Fixes: #2216

Description

There are some Broken links in readme.md

Changes

I have changed the broken links attached to white labelling, CSS Variables for non-React Projects and Rfcs in readme.md file

Component Checklist

  • Perform Manual Testing in Other Browsers

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: a12498c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

✅ PR title follows Conventional Commits specification.

@Anshgrover23 Anshgrover23 changed the title Update README.md docs: Update README.md Jul 18, 2024
Copy link

codesandbox-ci bot commented Jul 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a12498c:

Sandbox Source
razorpay/blade: basic Configuration

README.md Outdated
@@ -26,10 +26,10 @@ Blade is the Design System that powers [Razorpay](https://razorpay.com/).

## ✨ Features
- Cross-Platform (Works Natively on [React Web](https://blade.razorpay.com/?path=/docs/guides-installation--page#%EF%B8%8F-installation) and [React Native](https://blade.razorpay.com/?path=/docs/guides-installation--page#react-native-projects))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix these links as well? seems like they are broken too

Copy link
Contributor Author

@Anshgrover23 Anshgrover23 Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhdaware done. changed that broken links as well

@saurabhdaware saurabhdaware self-assigned this Jul 19, 2024
changed some more broken links
saurabhdaware
saurabhdaware previously approved these changes Jul 19, 2024
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🏅

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Anshgrover23
Copy link
Contributor Author

@saurabhdaware when it will get merged may i know sir?

@saurabhdaware
Copy link
Member

@saurabhdaware when it will get merged may i know sir?

Now 🤭 Sorry I was in meeting.

@saurabhdaware saurabhdaware merged commit 55779f3 into razorpay:master Jul 19, 2024
9 of 10 checks passed
@Anshgrover23
Copy link
Contributor Author

@saurabhdaware no worries and thanks for merging brother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in readme.md
2 participants