Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table selected ids #2324

Closed
wants to merge 2 commits into from
Closed

table selected ids #2324

wants to merge 2 commits into from

Conversation

anuraghazra
Copy link
Member

Add programmatic control for the selection state in the Table component.

  • Table Component (packages/blade/src/components/Table/Table.web.tsx):

    • Add new props selectedIds and defaultSelectedIds to the Table component.
    • Use the useControllableState hook to manage the controlled and uncontrolled selection state.
    • Update the onSelectChange function to set the selected rows without calling onSelectionChange directly.
    • Update the Table component to use the selectedIds prop for managing selection state.
  • API Stories (packages/blade/src/components/Table/docs/APIStories/TableAPI.stories.tsx):

    • Add examples of using the selectedIds and defaultSelectedIds props in the Table component.

For more details, open the Copilot Workspace session.

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 9287d12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 1, 2024

❌ PR title doesn't follow Conventional Commits specification.

Details:

No release type found in pull request title "table selected ids ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@saurabhdaware
Copy link
Member

Do we want to merge this @anuraghazra ?

@chaitanyadeorukhkar
Copy link
Collaborator

I've raised a PR for defaultselected ids with tests & everything. I think we can close this PR @anuraghazra ?

@anuraghazra anuraghazra closed this Oct 6, 2024
@anuraghazra anuraghazra deleted the anutable-selected-id branch October 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants