-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AccordionItemHeader to take full width #2357
Conversation
🦋 Changeset detectedLatest commit: cf3e3d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf3e3d0:
|
Bundle Size ReportUpdated Components
|
@Akshay090 please update snapshots and add changesets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the snapshots?
@@ -363,7 +363,7 @@ const _BaseHeader = ({ | |||
alignItems="center" | |||
justifyContent="space-between" | |||
> | |||
<Box>{children}</Box> | |||
{children} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can try giving the existing Box a flex={1}
or width="100%"
From what I remember, this exists because if in some case you pass multiple children component instead of one component, they will get rendered side-by-side because outer Box to this is a flex
Description
Changes
Additional Information
Component Checklist