Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AccordionItemHeader to take full width #2357

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

Akshay090
Copy link
Contributor

Description

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: cf3e3d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 10, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Sep 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf3e3d0:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Sep 10, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.464 7.467 +0.003 KB
DatePicker 85.362 85.369 +0.007 KB
Drawer, DrawerBody, DrawerHeader, drawerPadding 16.739 16.742 +0.003 KB
Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 28.002 28.004 +0.002 KB
Menu, MenuItem, MenuOverlay, MenuDivider, MenuFooter, MenuHeader 28.819 28.823 +0.004 KB
SideNav, SideNavLink, SideNavLevel, SideNavSection, SideNavItem, SideNavFooter, SideNavBody, SIDE_NAV_EXPANDED_L1_WIDTH_BASE, SIDE_NAV_EXPANDED_L1_WIDTH_XL 32.314 32.317 +0.003 KB
PhoneNumberInput 59.558 59.561 +0.003 KB

Generated by 🚫 dangerJS against cf3e3d0

@anuraghazra
Copy link
Member

@Akshay090 please update snapshots and add changesets.

@Akshay090 Akshay090 changed the title fix: accordion wrapper fix: AccordionItemHeader to take full width Sep 13, 2024
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the snapshots?

@@ -363,7 +363,7 @@ const _BaseHeader = ({
alignItems="center"
justifyContent="space-between"
>
<Box>{children}</Box>
{children}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can try giving the existing Box a flex={1} or width="100%"

From what I remember, this exists because if in some case you pass multiple children component instead of one component, they will get rendered side-by-side because outer Box to this is a flex

@saurabhdaware saurabhdaware merged commit c050c1d into master Sep 19, 2024
15 checks passed
@saurabhdaware saurabhdaware deleted the fix/accordion-wrapper branch September 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants