ZETA-6608: Add save-dev support for npm install. (#13)

razroo · Aug 31, 2023 · f6bf2f4 · f6bf2f4
1 parent ccb2537
commit f6bf2f4
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/src/npm/npm-install/npm-install.spec.ts b/src/npm/npm-install/npm-install.spec.ts
@@ -2,7 +2,7 @@ import { morphCommand } from "../../command-morph/command-morph";
 
 describe('npmInstall', () => {
   it('should return npm install with needed codemod', async() => {
-    const npmInstallCommandText = 'npm install apollo-angular react --save';
+    const npmInstallCommandText = 'npm install apollo-angular@5.0.0 react --save';
     const mockPackageJson = {
       name: 'hello', 
       dependencies: {
@@ -18,6 +18,29 @@ describe('npmInstall', () => {
     "apollo-angular": "5.0.0",
     "react": "18.2.0"
   }
+}`;
+    expect(result).toEqual(expected);
+  });  
+
+  it('should return npm install with needed codemod if saving as dev dependency', async() => {
+    const npmInstallCommandText = 'npm install apollo-angular@5.0.0 react@18.2.0 --save-dev';
+    const mockPackageJson = {
+      name: 'hello', 
+      dependencies: {
+        "angular": "16.0.0"
+      }
+    };
+    const stringifiedMockPackageJson = JSON.stringify(mockPackageJson);
+    const result = await morphCommand(npmInstallCommandText, stringifiedMockPackageJson);
+    const expected = `{
+  "name": "hello",
+  "dependencies": {
+    "angular": "16.0.0"
+  },
+  "devDependencies": {
+    "apollo-angular": "5.0.0",
+    "react": "18.2.0"
+  }
 }`;
     expect(result).toEqual(expected);
   });  

diff --git a/src/npm/npm-install/npm-install.ts b/src/npm/npm-install/npm-install.ts
@@ -12,8 +12,8 @@ export async function npmInstallCodemorph(commandText: string, packageJsonString
   }
 
   const packageJsonParsed = JSON.parse(packageJsonString);
-  const packageJsonDependencies = packageJsonParsed && packageJsonParsed.dependencies;
   const dependencyType = determineDependencyType(commandText);
+  const packageJsonDependencies = packageJsonParsed && dependencyType === 'dependencies' ? packageJsonParsed.dependencies : packageJsonParsed.devDependencies;
 
   const editInput: EditInput = {
     fileType: 'json',

diff --git a/src/utils/command-search/command-search.ts b/src/utils/command-search/command-search.ts
@@ -19,8 +19,8 @@ function containsDoubleAmpersand(input: string): boolean {
 export function extractPackageNames(commandText: string): string[] {
   const commandTextCleaned = commandText.replace(/npm/g, '')
     .replace(/install/g, '')
-    .replace(/--save/g, '')
     .replace(/--save-dev/g, '')
+    .replace(/--save/g, '')
     .replace(/;/g, '')
     .trim();