This repository was archived by the owner on Oct 29, 2019. It is now read-only.
Tag system #644
Open
Tag system #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatB
suggested changes
Apr 18, 2017
client/app/projects/blog/blog.less
Outdated
| } | ||
| .blog-tag .tech-tags { | ||
| padding : 0px; | ||
| margin-top: -10px; |
Contributor
There was a problem hiding this comment.
Spacing does not seem correct
server/api/user/index.js
Outdated
| router.put('/:id/:tech/removeTech', auth.canEdit(), controller.removeTech); | ||
|
|
||
| router.delete('/:id/project', auth.isAuthenticated(), controller.removeProject); | ||
| router.delete('/addTechBubble/:id/:tech', auth.isAuthenticated(), controller.removeProject); |
Contributor
There was a problem hiding this comment.
please follow convention of /:id/ first
| }); | ||
| }; | ||
|
|
||
| $scope.readOnly = function(){ |
Contributor
There was a problem hiding this comment.
Please use consistent naming.
Below this is called canEdit(), unless there's a specific reason to call this readOnly() it would be ideal to use the same name.
Member
|
@SaswatB ? |
Member
Author
|
@agundy what need to be fixed? |
Member
|
@agundy ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#eee is the same color as the background color of blog post.
feature of tag for blog:
1.tags will only get save when user trigger submit post.
2. remove the "+" button ------------- on the editblog page for tag.
| new tag | + <-----removed
--------------
Whenever + is hit, submit will be triggerred, user forced to exit blog edit popup. Problem did not occur when hitting enter for the same functionality.
edit blog:
blogs:
Honorable mention: @SaswatB
fixes: #580