This repository was archived by the owner on Apr 1, 2025. It is now read-only.
add Sample() to Timer, NilTimer, StandardTimer and TimerSnapshot #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes Sample() on Timer, just like it is already available on Histogram. This is necessary to know the number of measurements in a given sample (via
timer.Sample().Size()), which in turn is useful when gauging the "value" of different percentiles. For example, publishing the 99th percentile of a Timer is often pointless (or even misleading) if there are only 3 samples that contributed to that distribution.