-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Card): update type declarations #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwehrman
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
jazzyw and
soumyaloka
as code owners
July 27, 2023 21:00
arwehrman
changed the title
Fix/update card type declarations
Fix(card) type declarations
Jul 31, 2023
soumyaloka
changed the title
Fix(card) type declarations
fix(Card): update type declarations
Aug 1, 2023
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/Card.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardRadio.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardRadio.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardSection.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardSection.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardSection.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardTitle.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 1, 2023
packages/@lightningjs/ui-components/src/components/Card/CardTitle.d.ts
Outdated
Show resolved
Hide resolved
arwehrman
force-pushed
the
fix/update-card-type-declarations
branch
from
August 1, 2023 18:14
9c13d49
to
75b2274
Compare
Test Execution Passed. |
1 similar comment
Test Execution Passed. |
arwehrman
force-pushed
the
fix/update-card-type-declarations
branch
from
August 1, 2023 19:57
bc0511a
to
78cb9cb
Compare
Test Execution Passed. |
packages/@lightningjs/ui-components/src/components/Card/CardRadio.d.ts
Outdated
Show resolved
Hide resolved
arwehrman
force-pushed
the
fix/update-card-type-declarations
branch
from
August 2, 2023 13:36
78cb9cb
to
6f9db72
Compare
Test Execution Passed. |
arwehrman
force-pushed
the
fix/update-card-type-declarations
branch
from
August 2, 2023 14:25
6139f72
to
db68747
Compare
ImCoolNowRight
approved these changes
Aug 2, 2023
soumyaloka
approved these changes
Aug 2, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [@lightningjs/ui-components-v2.8.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.7.0...@lightningjs/ui-components-v2.8.0) (2023-08-02) ### Bug Fixes * **Badge:** update TS structure ([#303](#303)) ([f88a894](f88a894)) * **CardContent:** change cardContent doc backgroundColor ([#302](#302)) ([af4b1e1](af4b1e1)) * **Card:** update type declarations ([#308](#308)) ([bdddbb4](bdddbb4)) * **FocusManager:** add SignalMap to TypeConfig, update child components ([#305](#305)) ([f776394](f776394)) * **Gradient:** update TS structure ([#315](#315)) ([1282ef9](1282ef9)) * **Icon:** bug in Icon update ([#307](#307)) ([15ba7ac](15ba7ac)) * **InlineContent:** removes stage.update call from component ([#298](#298)) ([d2e84c2](d2e84c2)) * **label:** adds type declarations ([#311](#311)) ([4f124fe](4f124fe)) * **MetadataBase:** updates types declarations ([#318](#318)) ([2713f2c](2713f2c)) * **ProgressBar:** update TS structure ([#320](#320)) ([1f03be8](1f03be8)) * **TextBox:** functionality add to tone property ([#306](#306)) ([af2afc2](af2afc2)) ### Features * **Checkbox:** update TS structure ([#309](#309)) ([566a18c](566a18c))
🎉 This PR is included in version @lightningjs/ui-components-v2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates type declarations on Card, CardRadio, CardTitle, CardSection
References
LUI-994
Testing
Automation
Checklist