fix(Tile): update TS structure #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
from
1e53572
to
044632e
Compare
arwehrman
commented
Jul 28, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
|
Sanity Tests Execution Failed. |
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
2 times, most recently
from
81b5993
to
5d952e5
Compare
|
Test Execution Passed. |
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
from
3378aed
to
9c58689
Compare
arwehrman
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
jazzyw and
soumyaloka
as code owners
ImCoolNowRight
approved these changes
Aug 8, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
erautenberg
changed the title
anthony9187
reviewed
Aug 8, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 8, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 8, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
anthony9187
reviewed
Aug 8, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
from
2c9c0fa
to
c571b14
Compare
|
Test Execution Passed. |
3 similar comments
|
Test Execution Passed. |
|
Test Execution Passed. |
|
Test Execution Passed. |
|
can we add a signalmap for imageLoaded? Otherwise this looks good! |
anthony9187
reviewed
Aug 15, 2023
packages/@lightningjs/ui-components/src/components/Tile/Tile.d.ts
Outdated
Show resolved
Hide resolved
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
from
b3ef519
to
7d656e2
Compare
|
Test Execution Passed. |
arwehrman
force-pushed
the
fix/update-tile-type-declarations
branch
from
374bbf4
to
de13ee2
Compare
|
Test Execution Passed. |
anthony9187
approved these changes
Aug 22, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Aug 24, 2023
# [@lightningjs/ui-components-v2.11.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.10.0...@lightningjs/ui-components-v2.11.0) (2023-08-24) ### Bug Fixes * alias dimensions (w and h as width and height) ([#353](#353)) ([202860a](202860a)) * **Column:** scrollIndex takes presedence over alwaysScroll ([#342](#342)) ([955eb3c](955eb3c)) * **ListItem:** fix ListItem Description truncation Issue ([#344](#344)) ([3b7117c](3b7117c)) * simplify gutters ([#349](#349)) ([aaf384d](aaf384d)) * **Tile:** update TS structure ([#310](#310)) ([4641928](4641928)) ### Features * **MetadataCardContent:** update TS declarations ([#346](#346)) ([f353ee9](f353ee9)) * **TextBox:** add support for Marquee properties in TextBox ([#319](#319)) ([cc7103a](cc7103a))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Tile type declarations
References
LUI-843
Testing
Automation
Checklist