-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Storybook): upgrade to v8 #527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImCoolNowRight
force-pushed
the
feat/storybook-8-upgrade
branch
from
August 26, 2024 18:19
db6dc97
to
05068cd
Compare
ImCoolNowRight
requested review from
erautenberg,
joshhowenstine,
anthony9187,
soumyaloka,
ctoddy and
cee-money
as code owners
August 30, 2024 14:47
ImCoolNowRight
force-pushed
the
feat/storybook-8-upgrade
branch
from
August 30, 2024 14:47
fa6b9da
to
36c1c34
Compare
anthony9187
reviewed
Sep 3, 2024
anthony9187
approved these changes
Sep 3, 2024
joshhowenstine
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great for me!
che-effe
approved these changes
Sep 3, 2024
ImCoolNowRight
force-pushed
the
feat/storybook-8-upgrade
branch
from
September 12, 2024 13:39
36c1c34
to
c0b4066
Compare
ImCoolNowRight
force-pushed
the
feat/storybook-8-upgrade
branch
from
September 13, 2024 01:56
c0b4066
to
b735568
Compare
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Sep 19, 2024
# [@lightningjs/ui-components-v2.23.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.22.0...@lightningjs/ui-components-v2.23.0) (2024-09-19) ### Features * **Storybook:** upgrade to v8 ([#527](#527)) ([6c79934](6c79934))
🎉 This PR is included in version @lightningjs/ui-components-v2.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades our Storybook instance from v7 to v8.
NOTE: The Slider, SliderLarge, and ListItemSlider stories currently break due to
useArgs
. These uses have been commented out until we determine how best to implementuseArgs
with Storybook 8. (Invalid Hook Call Warning docs)References
N/A
Testing
Ensure all stories and docs load and operate correctly.
Automation
N/A
Checklist