Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storybook): upgrade to v8 #527

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

ImCoolNowRight
Copy link
Contributor

@ImCoolNowRight ImCoolNowRight commented Aug 26, 2024

Description

Upgrades our Storybook instance from v7 to v8.

NOTE: The Slider, SliderLarge, and ListItemSlider stories currently break due to useArgs. These uses have been commented out until we determine how best to implement useArgs with Storybook 8. (Invalid Hook Call Warning docs)

References

N/A

Testing

Ensure all stories and docs load and operate correctly.

Automation

N/A

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

Copy link
Contributor

@joshhowenstine joshhowenstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for me!

@ImCoolNowRight ImCoolNowRight merged commit 6c79934 into develop Sep 19, 2024
8 of 9 checks passed
@ImCoolNowRight ImCoolNowRight deleted the feat/storybook-8-upgrade branch September 19, 2024 20:12
svc-lightning-ui-components pushed a commit that referenced this pull request Sep 19, 2024
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants