Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodejs to docker-rdk-ci container #6

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Add nodejs to docker-rdk-ci container #6

merged 3 commits into from
Sep 13, 2024

Conversation

scthunderbolt
Copy link
Contributor

nodejs is required by Synopsis Coverity Reporting tool

shibu-kv and others added 3 commits June 21, 2024 07:21
@shibu-kv
RDKE-61: Use common GH context variables (#4) (#5)
dad9c15 
* RDKE-61: Use common GH context variables

* RDKE-61: Updates for pckage deploy
@scthunderbolt
Add nodejs to docker-rdk-ci container
8af63a8 
nodejs is required by Synopsis Coverity Reporting tool
@scthunderbolt
Fix verify-build workflow
c764b28
shibu-kv
shibu-kv reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@shibu-kv shibu-kv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shall we create the PR to develop instead.
The plan was to follow git flow model. So main would get changes as part of release process. And tagging would auto deploy the container to GHCR as well

@scthunderbolt scthunderbolt changed the base branch from main to develop September 13, 2024 16:18
@shibu-kv shibu-kv merged commit ad9755b into develop Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibu-kv shibu-kv shibu-kv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scthunderbolt @shibu-kv