Systest 9779 #137
Open
Systest 9779 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with linting or unit tests detected. For more information on our linting policies, please see our Linting-Guide. |
kschrief
requested changes
Jun 11, 2024
src/pubSubClient.js
Outdated
| } else { | ||
| logger.error('Failed to initialize a WS connection...', 'initialize'); | ||
| } | ||
| logger.error('Failed to initialize a WS connection...', event); |
There was a problem hiding this comment.
Let's leave this as "info". It will only technically be an error if someone wants to connect.
src/pubSubClient.js
Outdated
| reject(false); | ||
| }); | ||
| }).catch((error) => { | ||
| logger.error('Continuing without PubSub due to WS connection failure.'); |
kschrief
approved these changes
Jun 12, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enter a detailed description of the PR here, including the nature and purpose of the changes.
JIRA Ticket
Include a link to the JIRA Ticket linked to this PR.
Issue-0000
Additional Info (Test steps / Steps to reproduce etc.)
Details on how to test the feature