New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline dependencies on pubsub #230

Open

anjalimukundan wants to merge 12 commits into dev from Streamline_dependencies_on_pubsub

+18 −6

Contributor

anjalimukundan commented Oct 8, 2024

Description

Enter a detailed description of the PR here, including the nature and purpose of the changes.

JIRA Ticket

Include a link to the JIRA Ticket linked to this PR.
Issue-0000

Additional Info (Test steps / Steps to reproduce etc.)

Details on how to test the feature

neeradanelxsi and others added 2 commits

September 12, 2024 16:27


          Merge pull request #222 from rdkcentral/dev

fc4d7d6

Dev to Main Merge 9/12


          Streamline dependencies on pub sub

d1c300b

github-actions bot commented Oct 8, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/constant.js
  177:17  error  Replace `·:·"DEFAULT_APP_ID"` with `:·'DEFAULT_APP_ID'`  prettier/prettier
  178:14  error  Replace `·:·"DEFAULT_MAC"` with `:·'DEFAULT_MAC'`        prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/utils/Utils.js
  329:33  error  Delete `·`  prettier/prettier
  338:59  error  Insert `;`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.


          fixed lint issues

2d2b6cd

github-actions bot commented Oct 8, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/constant.js
  177:17  error  Delete `·`  prettier/prettier
  178:14  error  Delete `·`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.


          fixed lint issues

neeradanelxsi approved these changes

View reviewed changes


          updated default_mac logic

68d17f2

github-actions bot commented Oct 11, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  138:53  error  Insert `;`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

anjalimukundan and others added 4 commits

October 11, 2024 17:24


          fixed lint issues

1c91c04


          Merge branch 'dev' into Streamline_dependencies_on_pubsub

e840af6


          Merge branch 'dev' into Streamline_dependencies_on_pubsub

9e70488


          pubsub suffix changes

7ced300

github-actions bot commented Oct 15, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Replace `action)` with `·action);`              prettier/prettier
  398:50  error  Replace `query.params)` with `·query.params);`  prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/pubSubClient.js
  52:41  error  Replace `this.PUBSUB_SUBSCRIBE_TOPIC_SUFFIX)` with `·this.PUBSUB_SUBSCRIBE_TOPIC_SUFFIX);`  prettier/prettier
  53:39  error  Replace `this.PUBSUB_PUBLISH_TOPIC_SUFFIX)` with `·this.PUBSUB_PUBLISH_TOPIC_SUFFIX);`      prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.


          lint errors

6b79b24

github-actions bot commented Oct 15, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Insert `·`  prettier/prettier
  398:50  error  Insert `·`  prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/pubSubClient.js
  52:41  error  Insert `·`  prettier/prettier
  53:39  error  Insert `·`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.


          remove console logs

d4affd9

github-actions bot commented Oct 16, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> firebolt-certification@1.4.1 lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Insert `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.


          minor correction

69eff15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet