ci: add job and script for rdmo-app check #1
Conversation
MyPyDavid
force-pushed
the
dev-ci-add-rdmo-app-check
branch
from
491337c
to
ec8f1da
Compare
MyPyDavid
force-pushed
the
dev-ci-add-rdmo-app-check
branch
from
ec8f1da
to
4b8afbf
Compare
|
wanna review this as well @afuetterer?🙏 |
MyPyDavid
force-pushed
the
dev-ci-add-rdmo-app-check
branch
from
0d441a7
to
5cb00c2
Compare
| python manage.py check | ||
|
|
||
| # function for testing presence of plugin name in a certain django setting | ||
| test_if_settings_contain_plugin () { |
There was a problem hiding this comment.
thank you @triole! Ive included your suggestions and refactored the last part into a function. Looks good to you?
There was a problem hiding this comment.
Hmm, this is just testing that the plugin is in settings which is rather pointless, since the settings are part of the test setup. I think a simple ./manage.py check would suffice, right?
You got this. Glad you took it up to add some tests here. |
|
shall we merge this @jochenklar ? |
|
|
||
| git clone https://$GITHUB_TOKEN@github.com/rdmorganiser/rdmo.git | ||
| # need rdmo only for testing/config/settings | ||
| git clone https://$GITHUB_TOKEN@github.com/rdmorganiser/rdmo-app.git |
There was a problem hiding this comment.
I think the pluging can be tested in rdmo/testing/ alone, right? So cloning rdmo (no token needed) woulsd suffice.
| python manage.py check | ||
|
|
||
| # function for testing presence of plugin name in a certain django setting | ||
| test_if_settings_contain_plugin () { |
There was a problem hiding this comment.
Hmm, this is just testing that the plugin is in settings which is rather pointless, since the settings are part of the test setup. I think a simple ./manage.py check would suffice, right?
There was a problem hiding this comment.
This part should not be part of the repo. If it is only needed for testing it should just be part of the ci job.
There was a problem hiding this comment.
Maybe this can just be solved with some echo > magic and multiline yaml fields >-.
|
I would also like it better if the bash part would just be part of the yaml file. That makes it much easiert to see what the ci is doing. It is also easiert to move the script to other plugins. |
|
I think that actually this whole CI thing should go into its own repo, eg. |
|
Yes! I have not thought about it. Please go ahead if you can/want to work on it. I am curious how these things are implemented. |
|
I would like to propose a solution for this as well. I can work on the setup. But how to test this plugin actually works? What is a unit or integration test? Is the desired output the rendered dataset? |
Ive made a bash script for this job but it probably needs to be converted into the Action
ci.yml.Hope it runs 🤞