Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor upload accept #1156

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Refactor upload accept #1156

merged 9 commits into from
Feb 7, 2025

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Sep 26, 2024

This PR refactors the accept field for import plugins to match the format of react-dropzone, e.g.:

    accept = {
        'application/xml': ['.xml']
    }

The old style accept = '.xml' should still work. In this case mimetypes guesses the mime_type.

It also contains minor renaming in projectActions.

@MyPyDavid MyPyDavid added this to the RDMO 2.3.0 milestone Sep 30, 2024
@jochenklar jochenklar changed the base branch from 2.3.0 to 2.2.2 October 18, 2024 13:59
@jochenklar jochenklar changed the base branch from 2.2.2 to 2.3.0 October 18, 2024 14:04
@jochenklar jochenklar force-pushed the refactor_upload_accept branch from 0cc9bb3 to d456f9f Compare November 19, 2024 11:18
@jochenklar jochenklar self-assigned this Nov 19, 2024
@jochenklar jochenklar marked this pull request as ready for review November 19, 2024 11:20
@jochenklar jochenklar force-pushed the refactor_upload_accept branch from d456f9f to a0fcda2 Compare February 7, 2025 14:25
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, thanks!

@jochenklar jochenklar merged commit 6d6279d into 2.3.0 Feb 7, 2025
5 of 6 checks passed
@jochenklar jochenklar deleted the refactor_upload_accept branch February 7, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants