feat(interview): Interview fixes #1234
Conversation
|
wanna rename to Breadcrumb in here as well? |
rdmo/projects/assets/js/interview/components/main/widget/CheckboxWidget.js
Show resolved
Hide resolved
| def copy_project(project, site, owners): | ||
| from .models import Membership, Value # to prevent circular inclusion | ||
| def copy_project(instance, site, owners): | ||
| from .models import Membership, Project, Value # to prevent circular inclusion |
There was a problem hiding this comment.
this .import ... was already there but it's not so clean. It is only needed because of that get_value_path method which is imported from this utils.py in models.value.py and used by the Value.file_path method.
That function can also easily (in a quick check) be refactored into the models.value.py module and would make the imports normal at the top.
Should I add a refactor commit for that?
There was a problem hiding this comment.
As explained in the meeting utils.py should not import models module-wide.
There was a problem hiding this comment.
app.utils can only import models from other_app and not from app.models?
There was a problem hiding this comment.
only if other_app is "below" app in our made up apps hierarchy core < conditions|domain|...|views < projects.
There was a problem hiding this comment.
ok, but in this case everything is imported only from projects right? 😏
|
There were some other issues, but I think now I am done. Can I merge? |
This PR contains a set of (hopefully) last fixes and changes to the interview rework.