Skip to content
This repository was archived by the owner on Aug 30, 2020. It is now read-only.

Conversation

@onb3891
Copy link

@onb3891 onb3891 commented Oct 31, 2017

ESP32 xtensa toolchain

IngoMeyer441 and others added 30 commits March 15, 2016 08:58
    - PEP8 style doc string
    - Simplified patching (uses only re.sub)
    - Notification is printed when the patching function is invoked
Fixed AUR URL. AUR4 was temporary.
Addded avr, arm symlinks to fake toolchain
Add compatibility with Python2 and Python3
…83ecfc6

In the FAQ of https://github.com/Valloric/YouCompleteMe, there was an
issue of C++ standard library headers not found (ycm-core/YouCompleteMe#303)
that has been resolved with a workaround, and @cpradog has kindly implemented it.

However, this workaround has not yet been incorporated into template.py
in https://github.com/rdnetto/YCM-Generator, so adding this becomes the
main purpose of this fork.
Fixed the issue of C/C++ std headers not found on OSX
sorted() fails in python3 due to comparison of String and Tuple
This patch updates the README to reflect the support for
the meson (Ninja) build system.
Added meson + ninja support
Copy link
Owner

@rdnetto rdnetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore what I said earlier, the wrong target branch confused me.

Please raise the PR against develop so I can review your changes in isolation.

@onb3891
Copy link
Author

onb3891 commented Nov 11, 2017 via email

@rdnetto
Copy link
Owner

rdnetto commented Nov 12, 2017

I want to add support for ESP32 xtensa compilers. For that I need access to
repo, Can u provide that. I have these changes on a clone @
onb3891/YCM-Generator

You don't need write access to the repo - it should be sufficient for me to merge your changes in the PR.

The problem is that you've forked from the develop branch but raised your PR against stable, which means that I can't distinguish between the changes you've made and others on develop. This is why I'm asking you to edit the PR and set the target branch to develop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants