This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
RIP 0.1 Reach TypeScript Design Style Request #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs UnitTests for handling the string interpolation in VSCode notice some funny behaviour and documentation for creating additional plug-ins. |
chrisnevers
suggested changes
Jun 30, 2021
| @@ -0,0 +1,29 @@ | |||
| export enum CMD_HELPER { | |||
| COMPILE = <any>'compile', | |||
| @@ -1,6 +1,15 @@ | |||
| import { ExtensionContext } from 'vscode'; | |||
| import * as vscode from 'vscode'; | |||
|
|
|||
| const REACH_COMPILE_S:string = 'Reach Compile'; | |||
There was a problem hiding this comment.
same comments as previous PR
| @@ -0,0 +1,32 @@ | |||
| export class CONSTANTS { | |||
There was a problem hiding this comment.
I prefer only things that are used more than once are abstracted to constants. Otherwise, I find it easier to have the values inlined
| public static CANNOT_CREATE_SETTINGS:string = `Could not create .vscode/settings.json:`; | ||
| public static REACH_PATH:string = './reach'; | ||
| public static REACH_CLIENT_ID:string = 'reachide'; | ||
| public static CREATE_FILESYSTEM_WATCHER_PARAM:string = '**/*.rsh'; |
There was a problem hiding this comment.
public static RECURSIVE_REACH_FILE_SELECTOR : string = '**/*.rsh'
| public static fs = require('fs'); | ||
| public static url = require('url'); | ||
|
|
||
| public static REACH_IDE_S:string = 'Reach IDE'; |
| cmdHelper(value); | ||
| } | ||
|
|
||
| urlHelper(context, URL_HELPER.DOCS, URL_HELPER.DOCS_URL); |
There was a problem hiding this comment.
Maybe just make this:
const helperUrls = {
'docs': 'https://docs.reach.sh/doc-index.html',
// ...
}
for (const [key, value] of Object.entries(helperUrls)) {
urlHelper(context, key, value);
}
|
Thanks for the input valid points. I will add these style changes and resubmit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are areas in the code where the same string is used multiple times. I think it would be a good idea to start making these
constwherever possible.