Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:修复预览图片默认被设置成了缩略图的尺寸 #353

Closed

Conversation

JokerAn
Copy link

@JokerAn JokerAn commented Jun 5, 2024

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 2:23am

@JokerAn
Copy link
Author

JokerAn commented Jun 5, 2024

image

@yoyo837
Copy link
Member

yoyo837 commented Jun 5, 2024

@nova1751 @afc163 来看看

@wanpan11
Copy link
Contributor

wanpan11 commented Jun 5, 2024

ImgInfo 类型和 Preview 组件里面的 width heigth 也可以去掉

Preview 里面的图片应该是默认尺寸

@nova1751
Copy link
Contributor

nova1751 commented Jun 5, 2024

直接删掉不是特别可取,width和height应该改下名字防止作为属性生效

@wanpan11
Copy link
Contributor

wanpan11 commented Jun 5, 2024

直接删掉不是特别可取,width和height应该改下名字防止作为属性生效

Image 组件暴露出去的 width 和 height 是控制缩略图的,对于 Preview 的好像没有控制,ImgInfo 是在 imageRender 里的感觉给缩略图的宽高有点不对

@nova1751
Copy link
Contributor

nova1751 commented Jun 5, 2024

直接删掉不是特别可取,width和height应该改下名字防止作为属性生效

Image 组件暴露出去的 width 和 height 是控制缩略图的,对于 Preview 的好像没有控制,ImgInfo 里在 imageRender 里的感觉有点不对

这个只是作为信息传入的,用于获取图片信息,但没考虑到其作为html属性生效了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image组件预览的时候弹框中的图片被添加上了宽高
4 participants