Skip to content

Commit

Permalink
test: use unified github action yml (#670)
Browse files Browse the repository at this point in the history
  • Loading branch information
Layouwen authored Aug 27, 2024
1 parent df0fb1a commit 357d0a5
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 118 deletions.
119 changes: 5 additions & 114 deletions .github/workflows/react-component-ci.yml
Original file line number Diff line number Diff line change
@@ -1,115 +1,6 @@
name: CI

on: ['push', 'pull_request']

name: ✅ test
on: [push, pull_request]
jobs:
setup:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: '20'

- name: cache package-lock.json
uses: actions/cache@v4
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: create package-lock.json
run: npm i --package-lock-only --ignore-scripts

- name: hack for singe file
run: |
if [ ! -d "package-temp-dir" ]; then
mkdir package-temp-dir
fi
cp package-lock.json package-temp-dir
- name: cache node_modules
id: node_modules_cache_id
uses: actions/cache@v4
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

- name: install
if: steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: npm ci

lint:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v4

- name: restore cache from package-lock.json
uses: actions/cache@v4
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: restore cache from node_modules
uses: actions/cache@v4
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

- name: lint
run: npm run lint

needs: setup

compile:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v4

- name: restore cache from package-lock.json
uses: actions/cache@v4
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: restore cache from node_modules
uses: actions/cache@v4
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

- name: compile
run: npm run compile

needs: setup

coverage:
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@v4

- name: restore cache from package-lock.json
uses: actions/cache@v4
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: restore cache from node_modules
uses: actions/cache@v4
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package-temp-dir/package-lock.json') }}

- name: coverage
run: npm test -- --coverage

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}

needs: setup
test:
uses: react-component/rc-test/.github/workflows/test.yml@main
secrets: inherit
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ docs-dist/
.dumi/tmp
.dumi/tmp-production

bun.lockb
2 changes: 2 additions & 0 deletions bunfig.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[install]
peer = false
3 changes: 2 additions & 1 deletion docs/demo/input-control.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint no-console:0 */
import React from 'react';
import type { ValueType} from 'rc-input-number'
import InputNumber from 'rc-input-number';
import '../../assets/index.less';

Expand All @@ -9,7 +10,7 @@ export default () => {

return (
<div>
<InputNumber
<InputNumber<ValueType>
value={value}
max={999}
onChange={(newValue) => {
Expand Down
2 changes: 1 addition & 1 deletion docs/demo/simple.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default () => {
readOnly={readOnly}
disabled={disabled}
keyboard={keyboard}
wheel={wheel}
changeOnWheel={wheel}
stringMode={stringMode}
/>
<p>
Expand Down
5 changes: 3 additions & 2 deletions tests/props.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from 'react';
import '@testing-library/jest-dom';
import { render, fireEvent } from '@testing-library/react';
import KeyCode from 'rc-util/lib/KeyCode';
import type { ValueType } from '../src'
import InputNumber from '../src';

describe('InputNumber.Props', () => {
Expand Down Expand Up @@ -275,7 +276,7 @@ describe('InputNumber.Props', () => {
});

it('default value can be a string greater than 16 characters', () => {
const { container } = render(<InputNumber max={10} defaultValue='-3.637978807091713e-12' />);
const { container } = render(<InputNumber<ValueType> max={10} defaultValue='-3.637978807091713e-12' />);
const input = container.querySelector('input');
expect(input.value).toEqual('-0.000000000003637978807091713');
});
Expand Down Expand Up @@ -303,7 +304,7 @@ describe('InputNumber.Props', () => {
});

it('value can be a string greater than 16 characters', () => {
const { container } = render(<InputNumber max={10} value='-3.637978807091713e-12' />);
const { container } = render(<InputNumber<ValueType> max={10} value='-3.637978807091713e-12' />);
const input = container.querySelector('input');
expect(input.value).toEqual('-0.000000000003637978807091713');
});
Expand Down

0 comments on commit 357d0a5

Please sign in to comment.