Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): add setState condition in updateMiniStore method to avoid … #309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grantedFine
Copy link

add setState condition in updateMiniStore method to avoid infinite call in componentDidUpdate

@vercel
Copy link

vercel bot commented Feb 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/fot5i48vk
✅ Preview: https://menu-git-fork-grantedfine-fix-updateministore.react-component.now.sh

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #309 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   95.49%   95.50%   +0.01%     
==========================================
  Files          11       11              
  Lines         888      890       +2     
  Branches      265      267       +2     
==========================================
+ Hits          848      850       +2     
  Misses         40       40              
Impacted Files Coverage Δ
src/Menu.tsx 98.14% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5e6cb...08c1299. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Oct 28, 2020

conflict

@delete-merged-branch delete-merged-branch bot deleted the branch react-component:master March 31, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants