fix: improve week header cell styling #905

aojunhao123 · 2025-02-07T10:54:33Z

ref fix(a11y): fix empty table header for a11y and add localization support ant-design/ant-design#52689 (comment)

Summary by CodeRabbit

重构
- 简化了日期选择面板中周表头的渲染逻辑，移除了不必要的嵌套结构，同时保持了原有视觉效果和交互行为。

vercel · 2025-02-07T10:54:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
picker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2025 10:55am

coderabbitai · 2025-02-07T10:54:40Z

Walkthrough

此 PR 修改了 DatePanel 组件中用于展示周标题的渲染方式。原先通过元素包裹 {locale.week} 来达到隐藏视觉但占位的效果，现在直接在内渲染 {locale.week}，并设置了 pointerEvents 为 'none' 与 opacity 为 0，以保持相同的视觉效果。没有对外部或导出的实体声明进行变更。

Changes

文件	更改摘要
src/PickerPanel/DatePanel/index.tsx	在 DatePanel 组件中去除了多余的元素，直接在	内渲染 {locale.week}，并调整样式设置 pointerEvents 和 opacity，保持原有视觉布局。

Poem

我是一只奔跑的小兔，
代码跳跃着轻快的步，
繁复消散化简构，
{locale.week} 清新露出，
春风里我庆祝这改动，欢喜满额！

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/PickerPanel/DatePanel/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
at Function.resolve (node:internal/modules/helpers:145:19)
at Object. (/.eslintrc.js:2:21)
at Module._compile (node:internal/modules/cjs/loader:1546:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
at Module.load (node:internal/modules/cjs/loader:1317:32)
at Module._load (node:internal/modules/cjs/loader:1127:12)
at TracingChannel.traceSync (node:diagnostics_channel:315:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
at Module.require (node:internal/modules/cjs/loader:1339:12)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aojunhao123 · 2025-02-07T10:54:41Z

@afc163

codecov · 2025-02-07T10:56:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (abb12ba) to head (92bc772).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          64       64           
  Lines        2740     2740           
  Branches      770      770           
=======================================
  Hits         2616     2616           
  Misses        121      121           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/PickerPanel/DatePanel/index.tsx (1)
102-103: 优化周标题单元格的渲染实现！

代码变更简化了 DOM 结构，通过直接在 th 元素上设置样式来实现视觉隐藏效果，这是一个很好的改进。

不过建议考虑将内联样式抽离到一个常量或样式对象中，以提高代码的可维护性：
+const weekHeaderStyles = { pointerEvents: 'none', opacity: 0 } as const;
+
 if (prefixColumn) {
   headerCells.push(
-    <th key="empty" style={{ pointerEvents: 'none', opacity: 0 }}>
+    <th key="empty" style={weekHeaderStyles}>
       {locale.week}
     </th>,
   );
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8863871 and 92bc772.

⛔ Files ignored due to path filters (1)

tests/__snapshots__/panel.spec.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

src/PickerPanel/DatePanel/index.tsx (1 hunks)

aojunhao123 · 2025-02-07T12:10:31Z

不行，不能把样式改成这样。在某些占据空间较大的语种情况下，会把单元格挤得很宽。

yoyo837 · 2025-02-07T12:19:04Z

那就先不改呗，而且还动了DOM

aojunhao123 · 2025-02-07T12:19:11Z

我的建议是考虑一下tailwind和bootstrap都在用的sr-only类，考虑到了蛮多边界case和读屏器的兼容性。多出来的这些内联样式对性能的影响应该不大。

aojunhao123 · 2025-02-07T12:19:53Z

那就先不改呗，而且还动了DOM

这个改动其实还好，不会影响到正常使用

aojunhao123 · 2025-02-07T13:11:13Z

先关了，保持现状先

fix: improve week header cell styling

92bc772

vercel bot deployed to Preview February 7, 2025 10:55 View deployment

aojunhao123 mentioned this pull request Feb 7, 2025

fix(a11y): fix empty table header for a11y and add localization support ant-design/ant-design#52689

Merged

3 tasks

coderabbitai bot reviewed Feb 7, 2025

View reviewed changes

aojunhao123 closed this Feb 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve week header cell styling #905

fix: improve week header cell styling #905

aojunhao123 commented Feb 7, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 7, 2025 •

edited

Loading

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

aojunhao123 commented Feb 7, 2025

codecov bot commented Feb 7, 2025

coderabbitai bot left a comment

aojunhao123 commented Feb 7, 2025 •

edited

Loading

yoyo837 commented Feb 7, 2025

aojunhao123 commented Feb 7, 2025 •

edited

Loading

aojunhao123 commented Feb 7, 2025

aojunhao123 commented Feb 7, 2025

fix: improve week header cell styling #905

fix: improve week header cell styling #905

Conversation

aojunhao123 commented Feb 7, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Feb 7, 2025 • edited Loading

coderabbitai bot commented Feb 7, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

aojunhao123 commented Feb 7, 2025

codecov bot commented Feb 7, 2025

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

aojunhao123 commented Feb 7, 2025 • edited Loading

yoyo837 commented Feb 7, 2025

aojunhao123 commented Feb 7, 2025 • edited Loading

aojunhao123 commented Feb 7, 2025

aojunhao123 commented Feb 7, 2025

aojunhao123 commented Feb 7, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 7, 2025 •

edited

Loading

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

aojunhao123 commented Feb 7, 2025 •

edited

Loading

aojunhao123 commented Feb 7, 2025 •

edited

Loading