Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added non-passive event listener to a scroll-blocking #425

Open
mohamedLazyBob opened this issue Sep 24, 2021 · 1 comment
Open

Added non-passive event listener to a scroll-blocking #425

mohamedLazyBob opened this issue Sep 24, 2021 · 1 comment

Comments

@mohamedLazyBob
Copy link

I'm using antd, wich it self uses this package. and when using tabs I'm getting this warning in my console.

image

and when following the code, I think that this event listener should be passive/ non blocking because it's taking to much time
image
@haresh-samnani
Copy link

Any update on this warning?

rickwargo added a commit to rickwargo/tabs that referenced this issue Dec 14, 2022
@rickwargo
onWheel is a passive listener
5e20870 
onWheel should be a passive listener so it does not significantly slow down scrolling. It also resolves issue react-component#425 such that Chrome does not log a message to the console:
```
useTouchMove.js:154 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
```
@rickwargo rickwargo mentioned this issue Dec 14, 2022
Closed
@morfeii morfeii mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohamedLazyBob @haresh-samnani