Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make event listeners passive - useTouchMove.ts #651

Closed
wants to merge 1 commit into from

Conversation

puxiao
Copy link

@puxiao puxiao commented Feb 24, 2023

[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive.

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
tabs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 3:39AM (UTC)

@thomasJang
Copy link

image 从Chrome 117版本开始就出现了警告信息。 我希望这个问题能尽快修改。

@puxiao
Copy link
Author

puxiao commented Sep 20, 2023

好早我都提交 PR,但管理员一直没审核,没并入。

@morfeii
Copy link

morfeii commented May 20, 2024

Hi @zombieJ @afc163 @li-jia-nan
Apologies in advance if I tagged the wrong person, but I saw that you were contributing to this library.

I noticed that this PR addresses this issue, but it appears to be pending. (There's also an earlier duplicate of PR #625 )

Would it be possible to review and merge this PR? This fix is quite urgent for my project as it impacts performance and user experience. Your assistance would be greatly appreciated.

Thank you for your time and contribution to this great library!

Best regards,
Aleks

@afc163
Copy link
Member

afc163 commented Sep 29, 2024

Fixed in #723

@afc163 afc163 closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants