Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hiddenTextarea): A form field element should have an id or name attribute #59

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

zhe-he
Copy link
Contributor

@zhe-he zhe-he commented Jul 3, 2024

Form elements require a name or an ID, so I added a name to this element to resolve the browser warning

@zhe-he
Copy link
Contributor Author

zhe-he commented Jul 3, 2024

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (c0afd39) to head (a2f6e74).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files           3        3           
  Lines         205      206    +1     
  Branches       61       60    -1     
=======================================
+ Hits          203      204    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lomnus
Copy link

Lomnus commented Sep 15, 2024

什么时候可以merge呢 @afc163

@afc163 afc163 merged commit e231963 into react-component:master Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants