Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close popup when click iframe for click trigger #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add close popup when click iframe for click trigger #96

wants to merge 1 commit into from

Commits on Aug 13, 2018

  1. Add close popup when click iframe for click trigger 

    Using Trigger with `contextMenu` supports closing on window blur, in order to cover when a user clicks/taps on an iframe, but when we use `click` as a trigger, this was previously not supported.

This fix modifies the handler to support both click and contextMenu as valid triggers.

* simulates document click on window blur for both click and contextMenu triggers
* `contextMenuOutsideHandler1` renamed to `contextMenuScrollOutsideHandler` to be more descriptive about what case it is handling.
* `contextMenuOutsideHandler2` renamed to `clickBlurOutsideHandler` since it is the handler for click and contextMenu triggers (similar to `clickOutsideHandler`)
    @stephen-james
    stephen-james committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    bcdf1ee View commit details
    Browse the repository at this point in the history