Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: useNavigation hook is required with static api #1277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Johan-dutoit
Copy link

@Johan-dutoit Johan-dutoit commented Oct 5, 2023

You're no longer receiving the navigation prop when using the static api and must use the useNavigation hook

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit ea1afa9
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/651ecdf5e91fab0008f886c0
😎 Deploy Preview https://deploy-preview-1277--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. However I don't think navigation object not being passed is a limitation of the static API. It's a deliberate design decision.

I'm not sure about the best place for this info as this page has been reworked. Maybe we should have a new page static-api-differences-from-dynamic where we mention the changes. Ideas are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants