fix: checkbox style fixes #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview deployed Built with commit 2954100 https://deploy-preview-226--stoic-hodgkin-c0179e.netlify.com |
machikoyasuda
approved these changes
Aug 16, 2018
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Changes
When I pulled the Checkbox into the Reaction Meteor app, it did not display correctly. This was mostly due to using
rems. I've switched it to using ems and pixels as appropriate. For most values, em makes sense because as the font size of the checkbox label increases, it looks best if the checkbox increases proportionally.Also adds
isFormInput = truestatic property onCheckbox. Without this, it does not work correctly within a ReactoForm form.Breaking changes
None
Testing
Verify that the Checkbox component looks good in various browsers and if you play with the
font-sizeof the label and thehtmlroot, everything continues to look good.