Housekeeping: Reduce the versions of dependencies (#50)

reactivemarbles · May 31, 2021 · 495a72e · 495a72e
1 parent ee6b93e
commit 495a72e
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/src/ReactiveMarbles.NuGet.Helpers/NuGetPackageHelper.cs b/src/ReactiveMarbles.NuGet.Helpers/NuGetPackageHelper.cs
@@ -150,7 +150,7 @@ public static async Task<InputAssembliesGroup> DownloadPackageFilesAndFolder(
         /// <param name="nugetSource">Optional v3 nuget source. Will default to default nuget.org servers.</param>
         /// <param name="token">A optional cancellation token.</param>
         /// <returns>The best matching PackageIdentity to the specified version range.</returns>
-        public static async Task<PackageIdentity> GetBestMatch(LibraryRange identity, PackageSource nugetSource = null, CancellationToken token = default)
+        public static async Task<PackageIdentity> GetBestMatch(LibraryRange identity, PackageSource? nugetSource = null, CancellationToken token = default)
         {
             if (identity == null)
             {

diff --git a/src/ReactiveMarbles.ObservableEvents.SourceGenerator/AnalyzerReleases.Shipped.md b/src/ReactiveMarbles.ObservableEvents.SourceGenerator/AnalyzerReleases.Shipped.md
@@ -1,3 +1,7 @@
-; Shipped analyzer releases
-; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
+## Release 1.0
 
+### New Rules
+
+Rule ID | Category | Severity | Notes
+--------|----------|----------|--------------------
+RXPHARM001  | Compiler |  Warning   | 
diff --git a/src/ReactiveMarbles.ObservableEvents.SourceGenerator/EventGenerator.cs b/src/ReactiveMarbles.ObservableEvents.SourceGenerator/EventGenerator.cs
@@ -202,7 +202,9 @@ private static bool GenerateEvents(
                 return true;
             }
 
+#pragma warning disable RS1024 // Compare symbols correctly
             var processedItems = new HashSet<INamedTypeSymbol>(TypeDefinitionNameComparer.Default);
+#pragma warning restore RS1024 // Compare symbols correctly
 
             var fileType = isStatic ? "Static" : "Instance";
 

diff --git a/....ObservableEvents.SourceGenerator/ReactiveMarbles.ObservableEvents.SourceGenerator.csproj b/....ObservableEvents.SourceGenerator/ReactiveMarbles.ObservableEvents.SourceGenerator.csproj
@@ -7,13 +7,9 @@
     <DevelopmentDependency>true</DevelopmentDependency>
 	</PropertyGroup>
 
-	<PropertyGroup>
-		<RestoreAdditionalProjectSources>https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json ;$(RestoreAdditionalProjectSources)</RestoreAdditionalProjectSources>
-	</PropertyGroup>
-
 	<ItemGroup>
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.10.0-3.final" />
-		<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0-3.final" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0" />
+		<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.8.0" />
 		<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
 	</ItemGroup>
 </Project>
diff --git a/src/ReactiveMarbles.ObservableEvents.Tests/ReactiveMarbles.ObservableEvents.Tests.csproj b/src/ReactiveMarbles.ObservableEvents.Tests/ReactiveMarbles.ObservableEvents.Tests.csproj
@@ -19,7 +19,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0-3.final" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.9.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" PrivateAssets="all" />
     <PackageReference Include="ICSharpCode.Decompiler" Version="7.1.0.6543" />
   </ItemGroup>