Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add URL fragment tests #1900

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 1, 2024

  • Added fragment tests, ensuring that the fragment is always removed. ie /foo#name -> /foo
  • Updated InvalidParamSubstitutionShouldThrow
  • Added InvalidFragmentParamSubstitutionShouldThrow

This is to prevent future changes to Uri from breaking things. I'm looking at removing Uri and UriBuilder creation in RequestBuilderImplementation.
Out of curiosity why doesn't refit support fragments, is this intentional or an oversight?

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (6ebeda5) to head (98cc73d).
Report is 157 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   87.73%   84.89%   -2.85%     
==========================================
  Files          33       36       +3     
  Lines        2348     2502     +154     
  Branches      294      361      +67     
==========================================
+ Hits         2060     2124      +64     
- Misses        208      299      +91     
+ Partials       80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison TimothyMakkison changed the title Fragment tests feat: add URL fragment tests Nov 1, 2024
@ChrisPulman ChrisPulman merged commit e13386f into reactiveui:main Nov 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants