Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Commenting out FileProcessor but not corresponding ReferenceCreator terminates program #138

Open
cookersjs opened this issue Apr 14, 2020 · 0 comments
Assignees
Labels

Comments

@cookersjs
Copy link
Contributor

If you are trying to run specific AddLinks modules by commenting out portions of the context file, its possible to cause a premature termination of the program.

For example, in release 72 I meant to run everything except for HMDB processing/insertion, as they were going to be run separately. I had commented out the HMDBMetabolites and HMDBProteins File Processors, but I only commented out one of the two HMDB ReferencesCreators, mistakenly leaving one to be executed. When it came time to do that reference creation, the program terminated, likely due to a NullPointerException. Guarding for this, by either doing a check that any active FileProcessors/ReferenceCreators have their corresponding context active or just by outputting a warning message and continuing with the process would be good.

@cookersjs cookersjs added the bug label Apr 14, 2020
@SolomonShorser-OICR SolomonShorser-OICR self-assigned this Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants