Fix encoding of Href
query and fragment
#385
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we percent-decoded HREFs because we can have an EPUB with resources containing, for example, a percent character. The way it was implemented caused an issue with
http://
HREF with a fragment or query param containing special characters (e.g.%
or#
).To fix this, I adjusted the HREF parsing to not percent-decode the path but not the fragment and query params.