Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in the OPDS 2 parser #410

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Fix race condition in the OPDS 2 parser #410

merged 3 commits into from
Oct 9, 2023

Conversation

mickael-menu
Copy link
Member

Fixed

OPDS

  • Fixed race conditions causing ConcurrentModificationException to be thrown when parsing an OPDS 2 feed.

  • Removed the global feed property in the OPDS2Parser, this was the culprit for the ConcurrentModificationException.
  • Made all the OPDS models immutable.
    • To avoid messing up with the existing parsing code, I added an internal mutable builder for all the models. When we're ready to revamp the OPDS models and APIs, we can remove them.

@mickael-menu mickael-menu requested a review from qnga October 5, 2023 12:37
@mickael-menu mickael-menu merged commit 8f66880 into v3 Oct 9, 2023
3 checks passed
@mickael-menu mickael-menu deleted the fix/opds-models branch October 9, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants