Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR: Use dirhtml builder to see if #1407 works #1408

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benjaoming
Copy link
Contributor

Testing #1407 with dirhtml builder enabled

@benjaoming benjaoming changed the title Fix canonical in dirhtml with dirhtml builder Test PR: Fix canonical in dirhtml with dirhtml builder Jan 11, 2023
@benjaoming benjaoming force-pushed the fix-canonical-in-dirhtml-with-dirhtml-builder branch from 2f05bf1 to a58a587 Compare January 11, 2023 14:52
@benjaoming benjaoming marked this pull request as ready for review January 11, 2023 14:52
@benjaoming benjaoming requested a review from a team as a code owner January 11, 2023 14:52
@benjaoming benjaoming marked this pull request as draft January 11, 2023 14:53
@benjaoming
Copy link
Contributor Author

The test indicates that .html is trimmed. I'm not sure if the Canonical URL on PR builds is supposed to point to the stable branch, but it seems like a good idea to avoid search indexing PR builds.

@benjaoming benjaoming changed the title Test PR: Fix canonical in dirhtml with dirhtml builder Test PR: Use dirhtml builder to see if #1407 works Jan 11, 2023
@Blendify
Copy link
Member

@benjaoming
Copy link
Contributor Author

@Blendify responded here: #1407 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants