Use .filename attribute for CSS and JS files for pathto

[humitos]

Sphinx 7.2 changed how it handles the CSS and JS files internally and they cannot be treated as string anymore. We need to access to their .filename attribute to get the same behavior.

Closes #1502
Related #1463

[AA-Turner]

@humitos I believe css_tag should cover the use-cases in this theme, is there a reason why you can't use it, so that we might improve it?

A

[AA-Turner]

.filename was added in Sphinx 1.6.: sphinx-doc/sphinx@e6f8cd6

[agjohnson]

CI seems stuck, so I can't tell, but is this change compatible with Sphinx 5?

[humitos]

@humitos I believe css_tag should cover the use-cases in this theme, is there a reason why you can't use it, so that we might improve it?

I wasn't aware of it. I understand you refer to this, right?

https://github.com/sphinx-doc/sphinx/blob/6183b6abee561fc71c88fc66416d31a8f8ca009f/sphinx/builders/html/__init__.py#L1057-L1094

I will give it a try.

@agjohnson pinging you in case you know if there is a blocker about using these functions.

[humitos]

If we are OK using css_tag, there are more code we can update. For example:

sphinx_rtd_theme/sphinx_rtd_theme/layout.html

Lines 31 to 41 in 2b1d3fa

	{%- for css in css_files %}
	{%- if css|attr("rel") %}
	<link rel="{{ css.rel }}" href="{{ pathto(css.filename, 1) }}" type="text/css"{% if css.title is not none %} title="{{ css.title }}"{% endif %} />
	{%- else %}
	<link rel="stylesheet" href="{{ pathto(css.filename, 1) }}" type="text/css" />
	{%- endif %}
	{%- endfor %}
	{%- for cssfile in extra_css_files %}
	<link rel="stylesheet" href="{{ pathto(cssfile.filename, 1) }}" type="text/css" />
	{%- endfor -%}

[agjohnson]

@agjohnson pinging you in case you know if there is a blocker about using these functions.

Not off the top of my head. If there was a blocker, it would probably be projects with old/outdated configuration.

[humitos]

It seems we already did something similar to this PR in the past: #1101. I think we should take a look at both and merge them into the final PR 😄