Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix word wrapping in RST list-table #1506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsquyres
Copy link

  • Remove ".wy-table-responsive table td" CSS stanza

The diff on this PR is gigantic because the CSS is minified. The diff is effectively this:

$ diff -u theme.css-orig theme.css-new
--- theme.css-orig	2023-08-19 15:08:11
+++ theme.css-new	2023-08-19 15:08:22
@@ -1 +1 @@
-.wy-table-responsive table td,.wy-table-responsive table th{white-space:nowrap}
+.wy-table-responsive table th{white-space:nowrap}

This seems to fix #1505 for me, but I don't know if there's a historical or other deeper reason that that stanza is there in the CSS.

* Remove ".wy-table-responsive table td" CSS stanza

* Update assets
@jsquyres jsquyres force-pushed the pr/make-list-table-cells-wrap branch from a1891cb to 17e061b Compare August 20, 2023 15:56
@jsquyres
Copy link
Author

jsquyres commented Aug 20, 2023

I am not an expert in front-end dev things, but it looks like theme.css might actually be generated, and the source of the wy-table-responsive CSS stanzas comes from https://github.com/snide/wyrm/blob/master/sass/wyrm_core/_table.sass#L144-L151

Since this is not the ecosystem I typically work in, I'm not sure about the right way to proceed here. Is there a way to get word wrapping enabled in sphinx_rtd_theme tables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table cell text does not wrap in ".. list-table::"
1 participant