forked from react-native-webview/react-native-webview
-
Notifications
You must be signed in to change notification settings - Fork 0
Readwise/v13.16.0 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+179
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #import <WebKit/WebKit.h> | ||
|
|
||
| @interface RNCAssetSchemeHandler : NSObject <WKURLSchemeHandler> | ||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| #import "RNCAssetSchemeHandler.h" | ||
|
|
||
| @implementation RNCAssetSchemeHandler | ||
|
|
||
| - (void)webView:(WKWebView *)webView startURLSchemeTask:(id<WKURLSchemeTask>)urlSchemeTask { | ||
| NSURL *url = urlSchemeTask.request.URL; | ||
| NSString *path = url.path; | ||
|
|
||
| // Strip leading slash from path to get the filename | ||
| if ([path hasPrefix:@"/"]) { | ||
| path = [path substringFromIndex:1]; | ||
| } | ||
|
|
||
| // URL-decode the path (handles brackets and other special chars) | ||
| NSString *fileName = [path stringByRemovingPercentEncoding]; | ||
| if (!fileName || fileName.length == 0) { | ||
| NSError *error = [NSError errorWithDomain:NSURLErrorDomain code:NSURLErrorFileDoesNotExist userInfo:nil]; | ||
| [urlSchemeTask didFailWithError:error]; | ||
| return; | ||
| } | ||
|
|
||
| // Find the file in the app bundle | ||
| NSString *bundleResourcePath = [[NSBundle mainBundle] resourcePath]; | ||
| NSString *fullPath = [bundleResourcePath stringByAppendingPathComponent:fileName]; | ||
|
|
||
| if (![[NSFileManager defaultManager] fileExistsAtPath:fullPath]) { | ||
| NSError *error = [NSError errorWithDomain:NSURLErrorDomain code:NSURLErrorFileDoesNotExist userInfo:nil]; | ||
| [urlSchemeTask didFailWithError:error]; | ||
| return; | ||
| } | ||
|
|
||
| NSData *data = [NSData dataWithContentsOfFile:fullPath]; | ||
| if (!data) { | ||
| NSError *error = [NSError errorWithDomain:NSURLErrorDomain code:NSURLErrorCannotOpenFile userInfo:nil]; | ||
| [urlSchemeTask didFailWithError:error]; | ||
| return; | ||
| } | ||
|
|
||
| // Determine MIME type from extension | ||
| NSString *mimeType = @"application/octet-stream"; | ||
| NSString *ext = [fileName pathExtension]; | ||
| if ([ext isEqualToString:@"woff2"]) { | ||
| mimeType = @"font/woff2"; | ||
| } else if ([ext isEqualToString:@"ttf"]) { | ||
| mimeType = @"font/ttf"; | ||
| } else if ([ext isEqualToString:@"otf"]) { | ||
| mimeType = @"font/otf"; | ||
| } else if ([ext isEqualToString:@"woff"]) { | ||
| mimeType = @"font/woff"; | ||
| } | ||
|
|
||
| NSURLResponse *response = [[NSURLResponse alloc] initWithURL:url | ||
| MIMEType:mimeType | ||
| expectedContentLength:data.length | ||
| textEncodingName:nil]; | ||
|
|
||
| [urlSchemeTask didReceiveResponse:response]; | ||
| [urlSchemeTask didReceiveData:data]; | ||
| [urlSchemeTask didFinish]; | ||
| } | ||
|
|
||
| - (void)webView:(WKWebView *)webView stopURLSchemeTask:(id<WKURLSchemeTask>)urlSchemeTask { | ||
| // Requests complete synchronously, nothing to cancel | ||
| } | ||
|
|
||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is iOS 11+ only and I think we have a target of iOS 9? We should probably check if we need to safely escape if we are on an earlier version.