feat(jsonrpc): use func name for jsonrpc method by default#90
Merged
Tishka17 merged 2 commits intoreagento:developfrom Dec 7, 2025
Merged
Conversation
Tishka17
reviewed
Dec 6, 2025
Tishka17
reviewed
Dec 6, 2025
be84136 to
143138e
Compare
|
Tishka17
reviewed
Dec 6, 2025
| return instance.with_params( | ||
| JsonRPCMethod(func_or_parameter), | ||
| ) | ||
| elif isinstance(func_or_parameter, Transformer): |
Member
There was a problem hiding this comment.
Doesn't it break an order of tranformers?
Contributor
Author
There was a problem hiding this comment.
As far as I understand, new transformers are added at the beginning, and this is the very first transformer:
def with_params(
self,
*transformers: Transformer,
**params: Unpack[BuilderParams],
) -> "JsonRPCBuilder":
return JsonRPCBuilder(
*transformers,
*self.transformers,
**(self.params | params),
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We use the function name for the method if it's not explicitly specified.
For example, we currently support the following interface: