Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action rendering not scaled for non-default render size #140

Open
julienma96 opened this issue Feb 15, 2025 · 0 comments
Open

Action rendering not scaled for non-default render size #140

julienma96 opened this issue Feb 15, 2025 · 0 comments

Comments

@julienma96
Copy link

I believe I found a bug that appears twice in the code.

In the _render_frame method of class PushTEnv there is this code (lines 223-225):

coord = (action / 512 * 96).astype(np.int32)  # <--- bug: should be self.render_size instead of 96
marker_size = int(8/96*self.render_size)
thickness = int(1/96*self.render_size)

Same thing happens in the _get_obs method of class PushTImageEnv:

coord = (action / 512 * 96).astype(np.int32)  # <--- bug: should be self.render_size instead of 96

Question: Just to have my mental model right on this one: This affects only the cross that's solely used for visualization purposes right? So model training and inference is independent of the suggested change?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant